Fix progress display #4933
Merged
Fix progress display #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
rgrinberg
approved these changes
Sep 22, 2021
The progress display wasn't displayed during the first build. It was only displayed from the second build in polling mode. This was because of a `Status_line.set_constant None` in the function that scanned the source tree. The fix is to not clear the status line in this function, and instead use a "status line overlay". Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress wasn't displayed during the first build. It was only displayed from the second build in polling mode. This was because of a
Status_line.set_constant Nonein the function that scanned the source tree.The fix is to not clear the status line in this function, and instead use a "status line overlay".