fix dune clean on esy
#5507
Merged
fix dune clean on esy
#5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoRFS
added a commit
to marigold-dev/deku
that referenced
this pull request
Mar 7, 2022
- this patch can be removed after ocaml/dune#5507 is merged
EduardoRFS
added a commit
to marigold-dev/deku
that referenced
this pull request
Mar 7, 2022
- this patch can be removed after ocaml/dune#5507 is merged
EduardoRFS
added a commit
to marigold-dev/deku
that referenced
this pull request
Mar 7, 2022
- this patch can be removed after ocaml/dune#5507 is merged
EduardoRFS
added a commit
to marigold-dev/deku
that referenced
this pull request
Mar 7, 2022
- this patch can be removed after ocaml/dune#5507 is merged
|
Linked issue #5377 |
hcarty
reviewed
Mar 9, 2022
| @@ -116,9 +116,7 @@ and rm_rf_dir path = | |||
| deleted the directory. *) | |||
| ()) | |||
|
|
|||
| let rm_rf ?(allow_external = false) fn = | |||
| if (not allow_external) && not (Filename.is_relative fn) then | |||
| Code_error.raise "Path.rm_rf called on external dir" [ ("fn", String fn) ]; | |||
There was a problem hiding this comment.
This seems like a good check to keep when performing an operation this destructive.
There was a problem hiding this comment.
There was a problem hiding this comment.
But yes in general I would prefer removing this function.
rgrinberg
approved these changes
Mar 9, 2022
EduardoRFS
force-pushed
the
remove-external-directories
branch
from
b9d9eb1
to
b1ae470
Compare
Signed-off-by: EduardoRFS <theeduardorfs@gmail.com>
EduardoRFS
force-pushed
the
remove-external-directories
branch
from
b1ae470
to
81d58e4
Compare
|
Done boss |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Apr 15, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.1.0) CHANGES: - Add `sourcehut` as an option for defining project sources in dune-project files. For example, `(source (sourcehut user/repo))`. (ocaml/dune#5564, @rgrinberg) - Add `dune coq top` command for running a Coq toplevel (ocaml/dune#5457, @rlepigre) - Fix dune exec dumping database in wrong directory (ocaml/dune#5544, @bobot) - Always output absolute paths for locations in RPC reported diagnostics (ocaml/dune#5539, @rgrinberg) - Add `(deps <deps>)` in ctype field (ocaml/dune#5346, @bobot) - Add `(include <file>)` constructor to dependency specifications. This can be used to introduce dynamic dependencies (ocaml/dune#5442, @anmonteiro) - Ensure that `dune describe` computes a transitively closed set of libraries (ocaml/dune#5395, @esope) - Add direct dependencies to $ dune describe output (ocaml/dune#5412, @esope) - Show auto-detected concurrency on Windows too (ocaml/dune#5502, @MisterDA) - Fix operations that remove folders with absolute path. This happens when using esy (ocaml/dune#5507, @EduardoRFS) - Dune will not fail if some directories are non-empty when uninstalling. (ocaml/dune#5543, fixes ocaml/dune#5542, @nojb) - `coqdep` now depends only on the filesystem layout of the .v files, and not on their contents (ocaml/dune#5547, helps with ocaml/dune#5100, @ejgallego) - The mdx stanza 0.2 can now be used with `(implicit_transitive_deps false)` (ocaml/dune#5558, fixes ocaml/dune#5499, @emillon) - Fix missing parenthesis in printing of corresponding terminal command for `(with-outputs-to )` (ocaml/dune#5551, fixes ocaml/dune#5546, @Alizter)
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
esy uses
DUNE_BUILD_DIRpointing to an absolute directory, but since 0f31294 dune rejects removing any absolute directory, as a new checking was added.Leading to
dune cleanto fail, and also basic functionality such asdune build -w.Solution
This PR removes the checking, as the patch was likely a mistaken and not all absolute directories are external.