refactor: specialize [Fs_cache] to [Path.Outside_build_dir.t] #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowleopard
reviewed
Aug 27, 2022
rgrinberg
force-pushed
the
ps/rr/refactor__generalize__fs_cache_
branch
from
ca53c15
to
d39c21c
Compare
snowleopard
reviewed
Oct 5, 2022
snowleopard
changed the title
This makes all the types in this module as precise as possible Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 883fa61f-c6d1-41fd-8102-dee06ae24a88
rgrinberg
force-pushed
the
ps/rr/refactor__generalize__fs_cache_
branch
from
d39c21c
to
4814374
Compare
snowleopard
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the path type to vary. This is needed for the cache's to be keyed by
Path.Outside_build_dir.t.I can push the subsequent refactoring that changes the existing caches to use the more precise path type, but thought to do it in stages to keep the PR's small.