Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(melange): demonstrate build failure when target dir exists #6506

Merged

Conversation

anmonteiro
Copy link
Collaborator

This tests demonstrates an unintuitive error message when the melange.emit target directory exists.

I'm not sure what can be done about this, perhaps @rgrinberg has ideas.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/failure-if-target-exists branch from 36902db to ef546a6 Compare November 17, 2022 21:51
@rgrinberg
Copy link
Member

Making this an error sounds like a reasonable option. Another option might be to overlay the target dir with the source dir.

@rgrinberg rgrinberg merged commit 2745c4c into ocaml:main Nov 17, 2022
@anmonteiro anmonteiro deleted the anmonteiro/failure-if-target-exists branch November 20, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants