fix: raise when virtual library / implementations are in the same directory #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
commented
Nov 24, 2022
| @@ -217,7 +217,7 @@ let modules t ~for_ = modules_and_obj_dir t ~for_ |> fst | |||
|
|
|||
| let find_origin (t : t) name = Module_name.Map.find t.modules.rev_map name | |||
|
|
|||
| let virtual_modules lookup_vlib vlib = | |||
| let virtual_modules ~lookup_vlib vlib = | |||
There was a problem hiding this comment.
this is a drive-by refactoring that slipped through. Happy to revert.
rgrinberg
reviewed
Nov 24, 2022
test/blackbox-tests/test-cases/virtual-libraries/same-directory.t
Outdated
Show resolved
Hide resolved
rgrinberg
reviewed
Nov 24, 2022
|
Addressed both review comments. |
|
Does this need a changelog entry? |
add a test for a virtual library and its implementation defined in the same directory. currently this results in an ugly error crash Signed-off-by: David Sancho Moreno <dsnxmoreno@gmail.com>
introduce proper error message when virtual library / implementations are in the same directory Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
rgrinberg
force-pushed
the
anmonteiro/bug-virtual-libs
branch
from
d031c9c
to
6423da8
Compare
|
It's just an error message so it's fine to not include it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6550