Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not impose no_sandboxing on ocamldep #6749

Merged
merged 1 commit into from
Dec 27, 2022
Merged

fix: do not impose no_sandboxing on ocamldep #6749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ Unreleased
- Remove spurious build dir created when running `dune init proj ...` (#6707,
fixes #5429, @gridbugs)

- Allow `--sandbox` to affect `ocamldep` invocations. Previously, they were
wrongly marked as incompatible (#6749, @rgrinberg)

3.6.1 (2022-11-24)
------------------

Expand Down
2 changes: 1 addition & 1 deletion src/dune_rules/compilation_context.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ let create ~super_context ~scope ~expander ~obj_dir ~modules ~flags
let opaque = eval_opaque (Super_context.context super_context) opaque in
let ocamldep_modules_data : Ocamldep.Modules_data.t =
{ dir = Obj_dir.dir obj_dir
; sandbox
; sandbox = Sandbox_config.no_special_requirements
; obj_dir
; sctx = super_context
; vimpl
Expand Down