feature: add terminal ui backend based on NoTTY #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
c82067b
to
eadde66
Compare
Alizter
commented
Feb 4, 2023
rgrinberg
reviewed
Feb 4, 2023
rgrinberg
reviewed
Feb 4, 2023
rgrinberg
reviewed
Feb 4, 2023
rgrinberg
reviewed
Feb 4, 2023
rgrinberg
reviewed
Feb 4, 2023
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
eadde66
to
3b4bda3
Compare
|
I temporarily removed myself from the set of reviewers. @rgrinberg Once you are done reviewing and are happy with this PR, could you please ping me, so I can take a look? |
rgrinberg
reviewed
Feb 5, 2023
rgrinberg
reviewed
Feb 5, 2023
rgrinberg
reviewed
Feb 5, 2023
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
3b4bda3
to
d5d8de0
Compare
rgrinberg
reviewed
Feb 5, 2023
rgrinberg
reviewed
Feb 5, 2023
rgrinberg
reviewed
Feb 5, 2023
rgrinberg
reviewed
Feb 5, 2023
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
d5d8de0
to
cdb5505
Compare
Closed
rgrinberg
reviewed
Feb 6, 2023
rgrinberg
approved these changes
Feb 6, 2023
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
cdb5505
to
9c67a40
Compare
|
@Alizter could you rebase once more? |
|
@rgrinberg Not until #6994 is merged (otherwise it is a lot of work). |
|
#6994 has been merged |
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
9c67a40
to
bc145c9
Compare
<!-- ps-id: a91fcabe-9c8d-485c-a1e8-c781ed4658bd --> Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
from
bc145c9
to
66438e5
Compare
|
Thanks |
Alizter
deleted the
ps/rr/feature__add_terminal_ui_backend_based_on_notty
branch
nojb
added a commit
to nojb/dune
that referenced
this pull request
Jun 6, 2023
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 15, 2023
* main: (56 commits) feature: add terminal ui backend based on NoTTY (ocaml#6996) doc(coq): update documentation about coqdep fix(rules): don't descend into automatic subdirs infinitely (ocaml#7208) benchmark: add warm run (ocaml#7198) test: vendored and public libs (ocaml#7197) test: use sh in concurrent test (ocaml#7205) fix: custom log file path (ocaml#7200) test(melange): add test exercising ocaml#7104 (ocaml#7204) test(melange): add a test that introduces rules in the target dir (ocaml#7196) test: duplicate packages in vendor dir (ocaml#7194) melange: interpret `melc --where` as a list of `:`-separated paths (ocaml#7176) perf: add synthetic benchmark (ocaml#7189) Test case for bug report (ocaml#6725) Add test illustrating ocaml#6575 (ocaml#6576) chore: add rule streaming proposal (ocaml#7195) test(stdlib): merge wrapped/unwrapped tests test: move all stdlib tests fix: allow unwrapped libraries with `(stdlib ..)` test: demonstrate crash in modules.ml when `(stdlib .. )` used with `(wrapped false)` fix(install): respect display options (ocaml#7116) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new display mode
tuiwhich is based on NoTTY. This allows us to programmatically describe images before they are rasterized to the terminal.It also makes reasoning about what is drawn to the terminal easier in the future, if we ever want to communicate displays over RPC.
I plan to reimplement the TUI in the future with a more sophisticated UI. For now, this subsumes the behavior of old.