test: Demonstrate leaking of display for cram test #7003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/rr/test__demonstrate_leaking_of_display_for_cram_test
branch
from
03828f6
to
78a248a
Compare
rgrinberg
reviewed
Feb 5, 2023
Alizter
force-pushed
the
ps/rr/test__demonstrate_leaking_of_display_for_cram_test
branch
from
78a248a
to
1e6a6c3
Compare
rgrinberg
reviewed
Feb 5, 2023
|
|
||
| $ dune build --root=. --diff-command="exit 123" --display=short @runtest 2>&1 >/dev/null | head -n2 | ||
| File "mytest.t", line 1, characters 0-0: | ||
| sh (internal) (exit 1) |
There was a problem hiding this comment.
How is this possible? The command says exit 123 but the resultant exit code is 1?
There was a problem hiding this comment.
It appears that on the CI, Ubuntu also exits 123. In Nix and Mac it seems to be 1....
There was a problem hiding this comment.
For now I will set it to 1 as this doesn't appear to be our problem.
<!-- ps-id: bca52dae-c074-4edc-8022-073c2c7b551d --> Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/rr/test__demonstrate_leaking_of_display_for_cram_test
branch
from
1e6a6c3
to
0e6d333
Compare
Alizter
deleted the
ps/rr/test__demonstrate_leaking_of_display_for_cram_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the internal display bug from #4066.
cc @snowleopard