fix(cinaps): offer all promotions

CHANGES.md

@@ -1,6 +1,10 @@
 Unreleased
 ----------
 
+- Cinaps: The promotion rules for cinaps would only offer one file at a time no
+  matter how many promotions were available. Now we offer all the promotions at
+  once (#7901, @rgrinberg)
+
 - Do not re-run OCaml syntax files on every iteration of the watch mode. This
   is too memory consuming. (#7894, fix #6900, @rgrinberg)
 

src/dune_rules/cinaps.ml

@@ -180,11 +180,13 @@ let gen_rules sctx t ~dir ~scope =
     Action.Full.make ~sandbox
     @@ A.chdir (Path.build dir)
          (A.progn
-            (A.run (Ok cinaps_exe) [ "-diff-cmd"; "-" ]
-            :: List.map cinapsed_files ~f:(fun fn ->
-                   A.diff ~optional:true (Path.build fn)
-                     (Path.Build.extend_basename fn ~suffix:".cinaps-corrected"))
-            ))
+            [ A.run (Ok cinaps_exe) [ "-diff-cmd"; "-" ]
+            ; A.concurrent
+              @@ List.map cinapsed_files ~f:(fun fn ->
+                     A.diff ~optional:true (Path.build fn)
+                       (Path.Build.extend_basename fn
+                          ~suffix:".cinaps-corrected"))
+            ])
   in
   let cinaps_alias =
     Alias.make ~dir @@ Option.value t.alias ~default:cinaps_alias

test/blackbox-tests/test-cases/cinaps/concurrent-promotions.t

@@ -27,4 +27,7 @@ Cinaps should offer all promotions at once
   File "t1.ml", line 1, characters 0-0:
   Error: Files _build/default/t1.ml and _build/default/t1.ml.cinaps-corrected
   differ.
+  File "t2.ml", line 1, characters 0-0:
+  Error: Files _build/default/t2.ml and _build/default/t2.ml.cinaps-corrected
+  differ.
   [1]