Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add an action to test mirage #8061

Merged
merged 2 commits into from
Jul 27, 2023
Merged

ci: add an action to test mirage #8061

merged 2 commits into from
Jul 27, 2023

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Jun 27, 2023

This gives us a known-good configuration of Mirage to test against. The vast majority of the changes on the Dune side will not affect this, so it is not useful to add this to the regular CI; instead, this gives us a manual run to trigger at release time or on changes for which that can be useful.

@emillon emillon marked this pull request as ready for review June 27, 2023 15:39
@emillon emillon changed the title WIP: add an action to test mirage ci: add an action to test mirage Jun 27, 2023
@emillon emillon requested a review from TheLortex June 27, 2023 15:40
@emillon
Copy link
Collaborator Author

emillon commented Jun 27, 2023

@TheLortex This should correspond to the testing strategy you've showed me before; let me know what you think.

(I included pull_request: to iterate on this, because workflow_dispatch: runs are only available if they're merged in main first)

@emillon
Copy link
Collaborator Author

emillon commented Jun 27, 2023

I introduced the cross-compilation regression fixed in 3.8.1 but mirage-www does not seem to trigger the issue.

@emillon emillon mentioned this pull request Jun 28, 2023
16 tasks
@emillon
Copy link
Collaborator Author

emillon commented Jun 28, 2023

I updated the test to build caldav instead but still can't repro #7875 unfortunately

@emillon
Copy link
Collaborator Author

emillon commented Jul 6, 2023

I forgot to post an update: I updated this to use the caldav unikernel and was able to reproduce the issue. So it's in a reviewable state now.

@emillon emillon requested a review from rgrinberg July 6, 2023 14:02
@Alizter
Copy link
Collaborator

Alizter commented Jul 6, 2023

@emillon Can you run the action here so we can see it? Or does it not work from PRs?

@emillon
Copy link
Collaborator Author

emillon commented Jul 6, 2023

You can see the previous runs here.

@emillon
Copy link
Collaborator Author

emillon commented Jul 6, 2023

it does not run in PRs. you'll be able to trigger that manually once it has landed in main.

This gives us a known-good configuration of Mirage to test against. The
vast majority of the changes on the Dune side will not affect this, so
it is not useful to add this to the regular CI; instead, this gives us a
manual run to trigger at release time or on changes for which that can
be useful.

Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon merged commit 76861ec into ocaml:main Jul 27, 2023
19 of 22 checks passed
@emillon emillon deleted the ci-mirage branch July 27, 2023 13:35
pmwhite pushed a commit to pmwhite/dune that referenced this pull request Aug 10, 2023
* ci: add an action to test mirage

This gives us a known-good configuration of Mirage to test against. The
vast majority of the changes on the Dune side will not affect this, so
it is not useful to add this to the regular CI; instead, this gives us a
manual run to trigger at release time or on changes for which that can
be useful.

Signed-off-by: Etienne Millon <me@emillon.org>
pmwhite pushed a commit to pmwhite/dune that referenced this pull request Aug 10, 2023
* ci: add an action to test mirage

This gives us a known-good configuration of Mirage to test against. The
vast majority of the changes on the Dune side will not affect this, so
it is not useful to add this to the regular CI; instead, this gives us a
manual run to trigger at release time or on changes for which that can
be useful.

Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants