fix: correctly cancel failed builds #8062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowleopard
reviewed
Jun 27, 2023
rgrinberg
force-pushed
the
ps/rr/fix__correctly_cancel_failed_builds
branch
from
d69a6ec
to
6fb6df2
Compare
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: df0b278a-9093-4e90-bb02-616b5243fc8d -->
rgrinberg
force-pushed
the
ps/rr/fix__correctly_cancel_failed_builds
branch
from
6fb6df2
to
94f1ea3
Compare
|
Just tested internally, the fix works. |
|
@emillon this is a good candidate for 3.8.3 as well |
|
3.8.3 has already been released, unfortunately: ocaml/opam-repository#24007 |
|
I don't know how you feel about it, but perhaps 3.8.4?
…On Jun 27, 2023, 3:46 PM +0200, Etienne Millon ***@***.***>, wrote:
3.8.3 has already been released, unfortunately: ocaml/opam-repository#24007
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Definitely 3.8.4 if there's one, but I hope 3.9.0 (tomorrow) will be a painless upgrade so this will be a good way to deliver this fix. If it's difficult to release or has regressions that would warrant a 3.8.4. |
snowleopard
approved these changes
Jun 27, 2023
|
Just to say, I think this bug fix is pretty important: the watch mode was basically unusable without it for us internally. |
|
Turns out that the buggy commit never made it into any released versions. So there's no need for any bug fix releases. |
rgrinberg
added a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Jun 28, 2023
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
|
that's a relief. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rudi Grinberg me@rgrinberg.com