Use Marshal for the incremental and digest databases #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
ghost
requested a review
from 
rgrinberg
approved these changes
May 28, 2018
| val dump : Path.t -> D.t -> unit | ||
| val load : Path.t -> D.t option | ||
| end | ||
|
|
There was a problem hiding this comment.
Imo, having this stuff live in its own module is cleaner.
There was a problem hiding this comment.
Possibly, and maybe Cached_digest as well. We are just starting to have a lot of files in src/...
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much faster. On my machine, null builds of the Jane Street workspace go from ~2.7s to ~1.9s.