Don't warn on undefined opam variables when solving #8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undefined variables don't indicate a problem and packages expect comparisons with undefined variables to resolve to false. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
rgrinberg
reviewed
Jul 26, 2023
| try Ok (OpamFilter.eval_to_bool (Fun.const None) filter) | ||
| with Invalid_argument msg -> Error (`Not_a_bool msg))) | ||
| try Ok (OpamFilter.eval_to_bool ~default:false (Fun.const None) filter) | ||
| with Invalid_argument msg -> Error (`Not_a_bool msg) |
There was a problem hiding this comment.
Just a note: it's pretty undesirable to have to rely on catching this exception. It can be thrown by just about any function in the Stdlib so it's not reliable to use it a signal for anything in particular.
There was a problem hiding this comment.
I agree. This is a limitation of the opam api. We can obviously change the api of our vendored copy of opam but I try to keep such changes to a minimum to simplify the eventual backporting effort.
pmwhite
pushed a commit
to pmwhite/dune
that referenced
this pull request
Aug 10, 2023
Undefined variables don't indicate a problem and packages expect comparisons with undefined variables to resolve to false. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undefined variables don't indicate a problem and packages expect comparisons with undefined variables to resolve to false.