fix(pkg): improve locations of conversion errors

[rgrinberg]

We don't have the exact locations, but we can at least point to the
relevant files.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

[Alizter]

Can you add a test so we can see what it looks like?

[rgrinberg]

ping @Leonidas-from-XIV

[Alizter]

I still think it might be good to provide the package name and version in the message and not just the location.

[rgrinberg]

How would that information help? It's irrelevant to the error itself, therefore distracting. More is not better when it comes to error messages.

[Leonidas-from-XIV]

Looks good. The only concern I have is that the filename to the offending file might not be a particularly useful one, especially if it is read from a checkout in a cache directory or from a git object.

But lets not get future concerns prevent current improvements.

[rgrinberg]

Indeed, that's a good point. We could still be more helpful in such situations by including the commit, the repository URL, and the path. So at least the user knows where to find the file. We could even copy the file to a temporary directory.