fix(pkg): Only parse blob objects into files
#9352
Conversation
Leonidas-from-XIV
force-pushed
the
ignore-non-blobs
branch
from
ab3c30b
to
9de10eb
Compare
| Re.exec_opt re line | ||
| |> Option.bind ~f:(fun m -> | ||
| match Re.Group.get m 1 with | ||
| | "blob" -> |
There was a problem hiding this comment.
If we only want blobs, how about we modify the regex to accept only blobs?
There was a problem hiding this comment.
The reason I did it this way is because I was thinking that maybe we want to support commit objects by e.g. looking up through the commit id and exposing the tree that that commit is using.
|
Could you add a test case in a separate PR so that we can record the issue existing and then being fixed? |
|
@rgrinberg Sure, that actually prompted me into building a repo that has this exact issue that Ali described: #9372. I will rebase this PR on top of that when it is merged, since that repro test is much better than the one here. |
Leonidas-from-XIV
force-pushed
the
ignore-non-blobs
branch
2 times, most recently
from
6413867
to
a04b934
Compare
|
Rebased on top of the repro case and it shows that locking works now even in the presence of a |
Fixes ocaml#9328 Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
ignore-non-blobs
branch
from
a04b934
to
2e34bbf
Compare
While investigating #9328 it turns out that the tree has an object that's of type
commit. I originally thought that this was a symlink to nowhere (since the revision it points to does not exist) but it turns out it is something different as symlinks are represented as blobs after all.The code should discard these non-blob objects. However I don't yet know how to create a
commitobject for the repro case so for now it only tests broken symlinks. Any git-fu appreciated!Fixes #9328