New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg): Implement downloading sources via git #9506
feat(pkg): Implement downloading sources via git #9506
Conversation
The other option is to just |
I think this is the way to go. Note that if you add the I suggest unpacking the git repo using |
e0f0730
to
39717ce
Compare
Yes, that's a good point. The other issue is that it presumably clones everything, not just the repo but all other revisions as well. You can create a shallow clone but apparently only of a branch. The downside of |
Even a shallow clone wouldn't be enough as we don't really want to depend on the raw git objects. Those can contain a lot irrelevant data for any non trivial repo. Depending on tar is unfortunate, but we already do it for fetching via curl. We should definitely get rid of the extra dependencies eventually. |
Also cloning (shallow or not) only works when supplied with refs. Internally
So if we wanted to fetch specific revisions (at least with tie git CLI), we would probably need to create a tag for every single commit in the rev store. As such I would suggest merging this PR with |
39717ce
to
1e2889b
Compare
This adds an option to retrieve git sources via the rev store by adding the commits to the rev store and then materializing a repo in the target directory. Signed-off-by: Marek Kubica <marek@tarides.com>
1e2889b
to
d136e27
Compare
This adds an option to retrieve git sources via the rev store by adding the commits to the rev store and then materializing a repo in the target directory.