chore(pkg): Remove rudimentary git config parser in favor of git config
#9905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
changed the title
git configgit config
emillon
reviewed
Feb 2, 2024
emillon
reviewed
Feb 2, 2024
emillon
reviewed
Feb 2, 2024
emillon
reviewed
Feb 2, 2024
Leonidas-from-XIV
force-pushed
the
remove-git-config-parser
branch
from
6bcafd8
to
5864b33
Compare
Leonidas-from-XIV
force-pushed
the
remove-git-config-parser
branch
from
ff5c812
to
4fbf655
Compare
Leonidas-from-XIV
force-pushed
the
remove-git-config-parser
branch
3 times, most recently
from
9c46977
to
b063785
Compare
emillon
approved these changes
Feb 5, 2024
Leonidas-from-XIV
force-pushed
the
remove-git-config-parser
branch
from
b063785
to
bf141bd
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
remove-git-config-parser
branch
from
bf141bd
to
388c394
Compare
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Feb 8, 2024
…9905) Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the rudimentary config parser in favor of using
git config --list --blobwhich conveniently can just parse from any blob in the repo.This makes our parser match the git parser, thus no need for the parser tests anymore.