LSP: migrate to ppx_protocol_conv #948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
force-pushed
the
ppx-protocol-conv
branch
from
b384f13
to
2e462fc
Compare
|
I have the impression that ppx_protocol_conv brings a dependency on compiler-libs. The exact reason is not clear to me. But not much success so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of the work on #937.
So I started to translate the code from ppx_deriving_yojson to ppx_protocol_conv_json. There are some good things. For example it can translate a constructor with no argument to a string. So there is no need to write the conversion functions by hand in this case. On the other hand, it uses exception instead of the result type, which is a bit sad and annoying. So either the code must be adapted to catch the exceptions. Or we can ask upstream if using the result type would be possible.
The code doesn't compile yet but I haven't had time to work on it in the past few days. Pushing it here in case someone wants to help.