Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use findlib to decide the install directory #2

Closed
wants to merge 1 commit into from

Conversation

vbgl
Copy link

@vbgl vbgl commented Oct 27, 2017

The num library is no longer part of the standard library. As such, the install target of the Makefile should not attempt to install it in the directory that is dedicated to the standard library.

This patch lets findlib decide where to install the num library, according to user settings, as any other library.

BTW, the removal of the num library should be marked as “breaking” in the release notes of OCaml 4.06.

@gasche
Copy link
Member

gasche commented Oct 27, 2017

Well it was my understanding that installing num in the standard library directory was precisely meant to decrease incompatibilities -- for example to support people invoking ocaml nums.cma directly.

(I edited the OCaml Changes, thanks for the report)

@xavierleroy
Copy link
Contributor

Why didn't I think of that and went through the pains of installing the files semi-manually?

This would break all existing code that links with Num without going through ocamlfind. In a couple of years we might do that, but not now.

@vbgl vbgl deleted the findlib-install branch February 24, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants