Skip to content

Commit

Permalink
refactor: remove incorrect logging message
Browse files Browse the repository at this point in the history
Logging message claims that we ignore cancellation. That is not the case
and we handle it in both rpc.ml and the individual requests that care
about it.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 3d46cda3-8ac7-4aea-8380-041a912ab1fb -->
  • Loading branch information
rgrinberg committed May 25, 2023
1 parent e81d16a commit 4a787ea
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions ocaml-lsp-server/src/ocaml_lsp_server.ml
Original file line number Diff line number Diff line change
Expand Up @@ -700,9 +700,7 @@ let on_notification server (notification : Client_notification.t) :
in
let+ () = set_diagnostics state.detached (State.diagnostics state) doc in
state
| CancelRequest _ ->
Log.log ~section:"debug" (fun () -> Log.msg "ignoring cancellation" []);
Fiber.return state
| CancelRequest _ -> Fiber.return state
| ChangeConfiguration req ->
(* TODO this is wrong and we should just fetch the config from the client
after receiving this notification *)
Expand Down

0 comments on commit 4a787ea

Please sign in to comment.