Skip to content

Commit

Permalink
chore: remove uutf from deps (#1267)
Browse files Browse the repository at this point in the history 
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
  • Loading branch information
@rgrinberg
rgrinberg committed May 14, 2024
1 parent 3356a55 commit b8e0c0e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion dune-project
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ possible and does not make any assumptions about IO.
(ppx_expect (and (>= v0.15.0) :with-test))
(ocamlformat (and :with-test (= 0.24.1)))
(ocamlc-loc (>= 3.7.0))
(uutf (>= 1.0.2))
(pp (>= 1.1.2))
(csexp (>= 1.5))
(ocamlformat-rpc-lib (>= 0.21.0))
Expand Down
1 change: 0 additions & 1 deletion flake.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
stdune
yojson
ppx_yojson_conv_lib
uutf
merlin-lib
];
propagatedBuildInputs = [ ];
Expand Down
1 change: 0 additions & 1 deletion ocaml-lsp-server.opam
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ depends: [
"ppx_expect" {>= "v0.15.0" & with-test}
"ocamlformat" {with-test & = "0.24.1"}
"ocamlc-loc" {>= "3.7.0"}
"uutf" {>= "1.0.2"}
"pp" {>= "1.1.2"}
"csexp" {>= "1.5"}
"ocamlformat-rpc-lib" {>= "0.21.0"}
Expand Down

3 comments on commit b8e0c0e

@crackcomm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rgrinberg, uutf is still used in https://github.com/ocaml/ocaml-lsp/blob/d972723/lsp/src/dune#L6

@crackcomm
Copy link

@crackcomm crackcomm commented on b8e0c0e May 26, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you only removed it from ocaml-lsp-server.opam, not sure why my esy build fails 🙄

error: build failed with exit code: 1
  build log:
    # esy-build-package: building: @opam/ocaml-lsp-server@github:ocaml/ocaml-lsp:ocaml-lsp-server.opam#0ad159b
    # esy-build-package: pwd: /home/pah/.esy/3/b/opam__s__ocaml_lsp_server-ef2ad141
    # esy-build-package: running: 'dune' 'build' '-j' '6' 'ocaml-lsp-server.install' '--release'
    File "lsp/src/dune", line 6, characters 40-44:
    6 |  (libraries jsonrpc ppx_yojson_conv_lib uutf yojson)
                                                ^^^^
    Error: Library "uutf" not found.
    -> required by library "lsp" in _build/default/lsp/src
    -> required by executable main in ocaml-lsp-server/bin/dune:2
    -> required by _build/default/ocaml-lsp-server/bin/main.exe
    -> required by _build/install/default/bin/ocamllsp
    -> required by _build/default/ocaml-lsp-server.install
    error: command failed: 'dune' 'build' '-j' '6' 'ocaml-lsp-server.install' '--release' (exited with 1)
    esy-build-package: exiting with errors above...

  building @opam/ocaml-lsp-server@github:ocaml/ocaml-lsp:ocaml-lsp-server.opam#0ad159b
esy: exiting due to errors above

@rgrinberg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed here #1292.

Thanks for letting me know.

Please sign in to comment.