fix: kill dune ocaml-merlin in a friendlier way

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
ocaml · Jun 8, 2023 · c0bf37e · c0bf37e
1 parent 73678a6
commit c0bf37e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,9 @@
 
 ## Fixes
 
+- Kill unnecessary `$ dune ocaml-merlin` with SIGTERM rather than SIGKILL
+  (#1124)
+
 - Refactor comment parsing to use `odoc-parser` and `cmarkit` instead of
   `octavius` and `omd` (#1088)
 

diff --git a/ocaml-lsp-server/src/merlin_config.ml b/ocaml-lsp-server/src/merlin_config.ml
@@ -442,6 +442,6 @@ module DB = struct
     let* () = Fiber.return () in
     Table.iter t.running ~f:(fun running ->
         let pid = Pid.to_int running.process.pid in
-        Unix.kill pid Sys.sigkill);
+        Unix.kill pid Sys.sigterm);
     Fiber.Pool.stop t.pool
 end