Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: code coverage support #1064

Merged

Conversation

Alizter
Copy link
Contributor

@Alizter Alizter commented Apr 22, 2023

No description provided.

@rgrinberg
Copy link
Member

There's some relevant failures in CI

dune Outdated Show resolved Hide resolved
@Alizter Alizter force-pushed the ps/branch/feature__code_coverage_support branch from c1d1e66 to e65bdc9 Compare April 23, 2023 16:08
@rgrinberg
Copy link
Member

LGTM.

How come I don't see the coverage github action?

@Alizter
Copy link
Contributor Author

Alizter commented Apr 25, 2023

Oh It looks like I added it to the workflow in lev by mistake.

@Alizter Alizter force-pushed the ps/branch/feature__code_coverage_support branch from e65bdc9 to 9f6ef15 Compare April 25, 2023 00:23
@rgrinberg
Copy link
Member

There's this weird failure:

Error: request to https://api.github.com/repos/ocaml/opam-repository/contents/packages%2Focaml-base-compiler failed, reason: connect ETIMEDOUT 192.30.255.116:443

@Alizter Alizter force-pushed the ps/branch/feature__code_coverage_support branch 2 times, most recently from d77a855 to 9d04405 Compare April 25, 2023 22:13
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the ps/branch/feature__code_coverage_support branch from 9d04405 to 2afa675 Compare April 28, 2023 22:19
@rgrinberg rgrinberg merged commit d972723 into ocaml:master Apr 29, 2023
5 of 7 checks passed
@Alizter Alizter deleted the ps/branch/feature__code_coverage_support branch April 29, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants