feature: support --clientProcessId argument #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does nothing for now, but it's in the standard so it's better to at least explicitly ignore it. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 35ce0575-f2a8-47b6-a0fb-97cf408d86cd -->
rgrinberg
force-pushed
the
ps/rr/feature__support___clientprocessid_argument
branch
from
5589abe
to
d3cb46f
Compare
3Rafal
reviewed
May 2, 2023
| let spec = | ||
| [ ("--pipe", Arg.String (fun p -> t.pipe <- Some p), "set pipe path") | ||
| ; ("--socket", Arg.Int (fun p -> t.port <- Some p), "set port") | ||
| ; ("--stdio", Arg.Unit (fun () -> t.stdio <- true), "set stdio") | ||
| ; ( "--node-ipc" | ||
| , Arg.Unit (fun () -> raise @@ Arg.Bad "node-ipc isn't supported") | ||
| , "not supported" ) | ||
| ; ( "--clientProcessId" | ||
| , Arg.Int (fun pid -> t.clientProcessId <- Some pid) | ||
| , "set the pid of the lsp client" ) |
There was a problem hiding this comment.
I wonder if we should add an explicit remark about client pid being ignored. Currently, it's only mentioned in PR description. Maybe we should add it here?
There was a problem hiding this comment.
Note that this code is part of our general purpose lsp library. So we can't make assumptions whether it's being used or not.
3Rafal
approved these changes
May 2, 2023
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Jun 18, 2023
CHANGES: ## Fixes - Disable code lens by default. The support can be re-enabled by explicitly setting it in the configuration. (ocaml/ocaml-lsp#1134) - Fix initilization of `ocamlformat-rpc` in some edge cases when ocamlformat is initialized concurrently (ocaml/ocaml-lsp#1132) - Kill unnecessary `$ dune ocaml-merlin` with SIGTERM rather than SIGKILL (ocaml/ocaml-lsp#1124) - Refactor comment parsing to use `odoc-parser` and `cmarkit` instead of `octavius` and `omd` (ocaml/ocaml-lsp#1088) This allows users who migrated to omd 2.X to install ocaml-lsp-server in the same opam switch. We also slightly improved markdown generation support and fixed a couple in the generation of inline heading and module types. - Allow opening documents that were already open. This is a workaround for neovim's lsp client (ocaml/ocaml-lsp#1067) - Disable type annotation for functions (ocaml/ocaml-lsp#1054) - Respect codeActionLiteralSupport capability (ocaml/ocaml-lsp#1046) - Fix a document syncing issue when utf-16 is the position encoding (ocaml/ocaml-lsp#1004) - Disable "Type-annotate" action for code that is already annotated. ([ocaml/ocaml-lsp#1037](ocaml/ocaml-lsp#1037)), fixes [ocaml/ocaml-lsp#1036](ocaml/ocaml-lsp#1036) - Fix semantic highlighting of long identifiers when using preprocessors ([ocaml/ocaml-lsp#1049](ocaml/ocaml-lsp#1049), fixes [ocaml/ocaml-lsp#1034](ocaml/ocaml-lsp#1034)) - Fix the type of DocumentSelector in cram document registration (ocaml/ocaml-lsp#1068) - Accept the `--clientProcessId` command line argument. (ocaml/ocaml-lsp#1074) - Accept `--port` as a synonym for `--socket`. (ocaml/ocaml-lsp#1075) - Fix connecting to dune rpc on Windows. (ocaml/ocaml-lsp#1080) ## Features - Add "Remove type annotation" code action. (ocaml/ocaml-lsp#1039) - Support settings through `didChangeConfiguration` notification (ocaml/ocaml-lsp#1103) - Add "Extract local" and "Extract function" code actions. (ocaml/ocaml-lsp#870) - Depend directly on `merlin-lib` 4.9 (ocaml/ocaml-lsp#1070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does nothing for now, but it's in the standard so it's better to at
least explicitly ignore it.
Signed-off-by: Rudi Grinberg me@rgrinberg.com