Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove incorrect logging message #1104

Merged
merged 1 commit into from
May 26, 2023

Conversation

rgrinberg
Copy link
Member

Logging message claims that we ignore cancellation. That is not the case
and we handle it in both rpc.ml and the individual requests that care
about it.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

Logging message claims that we ignore cancellation. That is not the case
and we handle it in both rpc.ml and the individual requests that care
about it.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 3d46cda3-8ac7-4aea-8380-041a912ab1fb -->
@coveralls
Copy link

coveralls commented May 25, 2023

Pull Request Test Coverage Report for Build 3750

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 16.885%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/ocaml_lsp_server.ml 0 1 0.0%
Totals Coverage Status
Change from base Build 3733: 0.002%
Covered Lines: 3934
Relevant Lines: 23299

💛 - Coveralls

@rgrinberg rgrinberg merged commit 4d4f4cf into master May 26, 2023
10 of 13 checks passed
@rgrinberg rgrinberg deleted the ps/rr/refactor__remove_incorrect_logging_message branch May 26, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants