Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): move LogTrace to the correct location #1107

Merged

Conversation

rgrinberg
Copy link
Member

It's sent by the server to the client rather than the other way around.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

It's sent by the server to the client rather than the other way around.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: cca71bc4-fba5-4d44-a733-7b0ed0eb33e2 -->
@rgrinberg rgrinberg linked an issue May 26, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 26, 2023

Pull Request Test Coverage Report for Build 3753

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 16.886%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lsp/src/server_notification.ml 0 2 0.0%
Totals Coverage Status
Change from base Build 3733: 0.003%
Covered Lines: 3934
Relevant Lines: 23297

💛 - Coveralls

@rgrinberg rgrinberg merged commit 5ed6103 into master May 29, 2023
10 of 13 checks passed
@rgrinberg rgrinberg deleted the ps/rr/fix_lsp___move_logtrace_to_the_correct_location branch May 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$/logTrace is incorrectly specified as a client notification
2 participants