Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify file existence check #1120

Merged
merged 1 commit into from Jun 6, 2023

Conversation

rgrinberg
Copy link
Member

Signed-off-by: Rudi Grinberg me@rgrinberg.com

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: feab1807-5a74-43f1-949b-aa4f58f517bd -->
@coveralls
Copy link

coveralls commented Jun 6, 2023

Pull Request Test Coverage Report for Build 3794

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 17.404%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/merlin_config.ml 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/import.ml 1 35.9%
Totals Coverage Status
Change from base Build 3792: 0.003%
Covered Lines: 4072
Relevant Lines: 23397

💛 - Coveralls

@rgrinberg rgrinberg merged commit 9648a05 into master Jun 6, 2023
12 of 13 checks passed
@rgrinberg rgrinberg deleted the ps/rr/refactor__simplify_file_existence_check branch June 6, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants