Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency on workspace_root #1133

Merged
merged 1 commit into from Jun 15, 2023

Conversation

rgrinberg
Copy link
Member

It wa only used in one particular case where we need a location for a
diagnostic and doesn't give us one.

Instead, we use the dune instance's directory as the location.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

It wa only used in one particular case where we need a location for a
diagnostic and doesn't give us one.

Instead, we use the dune instance's directory as the location.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 5383325f-6217-4912-85eb-b604e3fbdc4b -->
@coveralls
Copy link

coveralls commented Jun 10, 2023

Pull Request Test Coverage Report for Build 3844

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 17.351%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/dune.ml 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/import.ml 1 35.9%
ocaml-lsp-server/src/ocaml_lsp_server.ml 1 36.47%
Totals Coverage Status
Change from base Build 3838: -0.002%
Covered Lines: 4072
Relevant Lines: 23469

💛 - Coveralls

@rgrinberg rgrinberg merged commit a16cd04 into master Jun 15, 2023
12 of 13 checks passed
@rgrinberg rgrinberg deleted the ps/rr/fix__remove_dependency_on_workspace_root branch June 15, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants