Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: killing merlin on windows #1136

Merged
merged 1 commit into from Jun 12, 2023

Conversation

rgrinberg
Copy link
Member

Signed-off-by: Rudi Grinberg me@rgrinberg.com

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 9da5364a-3501-49f0-9cf6-e99872eabf0e -->
@github-actions
Copy link

Pull Request Test Coverage Report for Build 3856

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 17.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/merlin_config.ml 0 1 0.0%
Totals Coverage Status
Change from base Build 3848: 0.004%
Covered Lines: 4073
Relevant Lines: 23471

💛 - Coveralls

@rgrinberg rgrinberg merged commit 11cc2ef into master Jun 12, 2023
13 of 14 checks passed
@rgrinberg rgrinberg deleted the ps/rr/fix__killing_merlin_on_windows branch June 12, 2023 09:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3856

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 17.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/merlin_config.ml 0 1 0.0%
Totals Coverage Status
Change from base Build 3848: 0.004%
Covered Lines: 4073
Relevant Lines: 23471

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants