Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extended hover request ocamllsp/hoverExtended #1145

Closed
wants to merge 2 commits into from

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Jun 18, 2023

Since #1103 the server can provide more information on hover request textDocument/hover.

Only the verbosity field was not implemented. This PR add verbosity config to extendedHover and remove the custom lsp request endpoint ocamllsp/hoverExtended.

Note: verbosity is optional. Default is 0.

@aspeddro aspeddro changed the title Remove extended hover request ocamllsp/extendedHover Remove extended hover request ocamllsp/hoverExtended Jun 18, 2023
@rgrinberg
Copy link
Member

We can't really remove existing requests just like that. That would be a breaking change which I would argue is unnecessary.

Also, IIUC, this PR argues that to replicate the old behavior it's enough to just set the config appropriately. While that's possible, I think this API is brittle. In particular, it doesn't work well when there's requests being made automatically by the client and they all rely on different settings. It's also inferior when you consider users automating their editor using LSP requests. Now they would need to remember to set the config and then restore it.

@aspeddro aspeddro closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants