Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nix): allow overriding ocaml version #1264

Merged
merged 1 commit into from
May 14, 2024

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented May 12, 2024

Also set a custom source for merlin as it's something we very often need to change.

@rgrinberg rgrinberg force-pushed the ps/rr/chore_nix___allow_overriding_ocaml_version branch from b15cd4c to dbbb7d8 Compare May 13, 2024 01:54
@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 4191

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 21.171%

Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/import.ml 1 26.19%
Totals Coverage Status
Change from base Build 4187: -0.005%
Covered Lines: 5104
Relevant Lines: 24108

💛 - Coveralls

@rgrinberg rgrinberg force-pushed the ps/rr/chore_nix___allow_overriding_ocaml_version branch 2 times, most recently from 7564c5c to 9cc8c8e Compare May 13, 2024 04:24
@rgrinberg rgrinberg force-pushed the ps/rr/chore_nix___allow_overriding_ocaml_version branch from 9cc8c8e to 3346f0d Compare May 13, 2024 04:45
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 964e844d-4ada-4717-a72b-6926b4c0cd9a -->
@rgrinberg rgrinberg force-pushed the ps/rr/chore_nix___allow_overriding_ocaml_version branch from 3346f0d to 424e9c7 Compare May 13, 2024 16:09
@rgrinberg rgrinberg merged commit 3356a55 into master May 14, 2024
8 of 9 checks passed
@rgrinberg rgrinberg deleted the ps/rr/chore_nix___allow_overriding_ocaml_version branch May 14, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants