Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name all merlin pipelines #1276

Merged
merged 2 commits into from
May 17, 2024

Conversation

awilliambauer
Copy link
Contributor

Add names to all merlin pipelines that currently lack a name. This is helpful for implementing telemetry—Jane Street's internal ocaml-lsp telemetry uses these names. This PR should have no impact otherwise.

@coveralls
Copy link

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 4224

Details

  • 5 of 18 (27.78%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 21.155%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/custom_requests/req_wrapping_ast_node.ml 0 1 0.0%
ocaml-lsp-server/src/rename.ml 0 1 0.0%
ocaml-lsp-server/src/custom_requests/req_typed_holes.ml 0 2 0.0%
ocaml-lsp-server/src/document.ml 3 5 60.0%
ocaml-lsp-server/src/ocaml_lsp_server.ml 0 3 0.0%
ocaml-lsp-server/src/definition_query.ml 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/document.ml 1 60.0%
Totals Coverage Status
Change from base Build 4221: 0.001%
Covered Lines: 5138
Relevant Lines: 24287

💛 - Coveralls

_
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg merged commit ec53219 into ocaml:master May 17, 2024
8 of 9 checks passed
@awilliambauer awilliambauer deleted the name-all-merlin-pipelines branch May 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants