Restore 4.06 support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also restores support for 4.06
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
|
I've tested it out and it seems to work on 4.06 and it works fine. |
It's already vendored Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
On linux, raise_with_backtrace threw `Error: junk `raise_with_backtrace (%rip)' after expression` We support 4.06 by rely on reraise on 4.06 Possibly related: ocaml/ocaml#1557 ocaml/ocaml#1465 ocaml/ocaml#378 ocaml/ocaml#7666
|
CI fails with Tested find at vscode-merlin with my fork: arrowresearch/vscode-merlin#49 |
|
We forgot to update the merlin submodule to rgrinberg/merlin#fb90bf00d3 |
|
Also, should I look into 4.07 support? Or do you think we can revisit it later? |
|
I think it's fine to revisit it later.
Could you send a PR for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.