Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate doc.css anchor target styles, adjust hover styles #1014

Merged
merged 1 commit into from Mar 28, 2023

Conversation

sabine
Copy link
Collaborator

@sabine sabine commented Mar 27, 2023

Since .prose is applied to the odoc output in the package documentation section, hover styles for the anchor elements in the headings were applied twice since #628. This patch removes the anchor target styles in doc.css, so that only one set of anchor target styles is applied.

Patch also changes the style of the hover effect because the # symbol would, on small screens, and when there are no sufficient margins, be cut off.

before after
Screenshot from 2023-03-27 12-34-26 Screenshot from 2023-03-27 12-34-33
# is cut off at the edge of the browser window. In package docs, two # are rendered on hover hover effect now requires just a very small margin and is applied only via .prose

@sabine sabine marked this pull request as ready for review March 27, 2023 10:40
@sabine sabine merged commit 9df53e2 into ocaml:main Mar 28, 2023
3 checks passed
@sabine sabine deleted the move_hashtags_on_titles branch March 28, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants