Use Ocamlorg_static.Media.url for media #1163
Conversation
|
Looks good to me. We also need to go through all the templates to see where media files are being used and then use the new function to render the digest-URL. Media is everything that lives in the ETA: every kind of data in the One type of media files that we won't be able to serve under digest URLs are the ones which are referenced from within the body of a markdown ( |
r17x
force-pushed
the
feat/media
branch
2 times, most recently
from
4febf8f
to
5ac04b4
Compare
|
Hello @sabine 👋 Sorry for my late updates. I have been resolved conflicts after main branch updated and implemented Ocamlorg_static.Media.url in templates. See the differences between this branch and ocaml.org (image attachments) # in main branch or ocaml.org
-- /media/books/ocaml-scientific-computing.png
# in this branch after use Ocamlorg_static.Media.url
++ /media/_/OTg1ZWQ3NWMzZTZkYzVjNDRjN2VkY2FiNWJjNjEzMzk/books/ocaml-scientific-computing.png
|
There was a problem hiding this comment.
Looks good to me! Thanks for the contribution!
This issue is great to be resolved because, now, organizations can update their logo and there will be no issues with users' browsers still caching an old version. 👍
Never worry about taking time... we intentionally choose these issues so they are not time critical. After all, this is open source, and it's super nice of you to contribute! From our side, the goal is to provide a space where we can learn from each other and collaborate while making OCaml.org as useful to the community as we all can. 🙂
The aspect of providing space for collaboration and learn from each other is an interesting in the OCaml community. Thanks for providing the space. |
Closes #1147
Hello @sabine , I have been make a PRs related with #1147 but not sure of my implementation is correct (meet the expectation).
Feel free for make a Review for this PRs
Thanks