split jsoo toplevel into web-worker #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricoferris
force-pushed
the
web-worker
branch
from
928be20
to
1fb8a11
Compare
tmattio
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
This looks so good! 🤩
The user experience looks great and we'll really see the difference in terms of performance.
I do have a slight preference for a dark-themed top level, but we can revisit it when we come back on the design of the homepage.
Feel free to merge when you feel this is ready!
|
macOS errors are probably from ocaml/opam-repository#19676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to partially fix #133 and #127 by moving the jsoo execution to a web worker which makes the chunk of the code easier to lazy load, execution of OCaml code doesn't block the main UI thread, easy to terminate the worker if there is no response in a certain amount of time (here
10s). It also gives the toplevel a bit of a different UI just to work in the idea of having to load the toplevel runtime code in. The initial JS loaded into the homepage is now (afterdune build --profile release)~80kBgzipped (~213kBotherwise) which is better (we could probably go further, but perhaps in a separate PR)Toplevel after loading the home page
Toplevel after clicking load and entering a few expressions