New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure layout of playground #1384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of @contificate's changes to the playground’s layout. The code seems to be introducing the desired effects without altering any other aspects of the view, thus ensuring that all the previous functionality remains unaltered and usable, moreover it is finally addressing the bug which always placed the Find & Replace widget out of view, hence, hopefully, aiding in providing a more contoured UX.
Thanks so much @contificate and @StonedHesus, this is looking really good! Uncovering the Find/Replace UI is super useful - I didn't even know that existed! 👍 Sorry I didn't get to review it properly yet, I'm still saying "yes" to too many things, so everything is busy at the moment. 🙂 There's a few things I need to think through, namely
Besides that, when we decide to go with Regardless, this is a great improvement, and we can still look at the mobile view at another time. I hope to merge this by end of this week or early next week. |
@sabine I appreciate you taking your time to thank @contificate and I for pointing this here UI issue, though the credit ought to be attributed solely to @contificate since he was the one who ended up implementing the actual solution to the UI problem. As for reviewing the code changes yourself, do bide your time with it, for I am quite sure that it isn't that pressing of a matter. Now when it comes to the UI for mobile platforms, I think I have some suggestions, we can discuss more in the days and weeks to follow over Discord, but in the meantime I think that we ought to open an issue for that, that is if there isn't one already opened. And, in addition to that, we also need to establish how we can collaborate on the design process directly in Figma, so as to agree upon layout modification prior to implementing them in the codebase. |
I happened to find some time this morning. Since there was some trouble with the mobile layout and I also moved all the CSS into the I think this is in a good shape to merge like this. I opened #1391 for the task of creating mobile view. Regarding Figma, I have to check on our designer and see where we will have a space to co-design and review designs. |
This set of changes seeks to addres issue #1381. - Add split.js splitter between code editor and output pane. This is somewhat a novelty feature, but I believe it could prove useful on limited displays, also permitting the easy extension of other features (such as a future settings window, which could be configured to hide to make most use of display real estate). - Address issue where text disappears beneath the bar containing the "Run" button. Previously, this button was placed absolutely to account for the difficulty of laying codemirror out in a flex layout. I believe this is now resolved. - Address issue where full page height is not being utilised. This is achieved by flexing the entire body of the playground page, so the content area can sit below it, flexed. - Ascribe an identifier, "output-area", to the relevant element to be scrolled in a future feature addition. The CSS additions have been put into a fresh asset file. The reason being that I haven't yet gotten around to considering if there's any reasonable conflicts or redundancies with codemirror.css.
Commit message:
I've tested these changes and believe them to work on every major browser. I'm hoping someone can review the changes to get a feel for the difference. The only really opinionated thing is the layout now exists within a split pane (provided by https://split.js.org/ - MIT License, simple) to allow for some flexibility on limited displays.
My hope is that, with these changes, room for addressing other issues - which may involve the addition of extra UI elements - has been made.
Please be sure to flag up any layout related issues you encounter.