New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tutorial about arrays #1405
Conversation
Do go ahead and rename the files to have the proper order. It's more obvious when the order in the directory maps directly to the order on the page, rather than doing another sorting step in the template/handler. |
I've renamed the files. |
This branch: https://github.com/ocaml/ocaml.org/tree/array-tutorial has an additional review & update commit. Not sure if the issue comes from me or GH, but I can't push here directly. |
I've cherry-picked your commit, thanks for the review! |
There's another one in the same branch ontop of the first |
4ccb8cb
to
728cb0f
Compare
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor grammar / syntax stuff, but I did suggest a change in two code blocks -- to included the prompt for clarity.
|
||
In OCaml, arrays are collections of elements of the same type that are stored in contiguous memory locations. They are mutable, each value can be updated, but they have a fixed size; which set them apart from lists. | ||
|
||
Despite these differences many of the functions readily available on arrays are similar to the ones available for lists, please refer to the [List tutorial](https://ocaml.org/docs/lists) and documentation for more details about these functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be helpful to mention some example before urging new users/readers back to the List tutorial.
Despite these differences, many of the functions readily available on arrays are similar to the ones available for lists such as X, Y, and Z. Please refer to the List tutorial and documentation for more details about these functions.
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: tuohy <g.tuohy@outlook.com>
Did we address all of https://discuss.ocaml.org/t/feedback-needed-new-arrays-tutorial-on-ocaml-org/12683? |
I didn't meddle with the order of tutorials (I would place it after the List tutorial). Currently it relies on the alphabetical order of the file names, it would be nice to modify that order without renaming files, in the template directly maybe?