Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make playground/gen_stdlib.sh mac compatible #1469

Merged
merged 2 commits into from Aug 23, 2023
Merged

Conversation

gpetiot
Copy link
Contributor

@gpetiot gpetiot commented Aug 2, 2023

Got some issues on mac, let's see if the CI is okay with this change.

@gpetiot gpetiot marked this pull request as ready for review August 2, 2023 12:34
Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. However, with this patch, we can no longer use a local switch for the playground.

I was a bit confused at some point before about why the playground Makefile creates a named global switch, while the ocaml.org Makefile creates a local switch. This sounds like a recipe for potential trouble to me: When the playground uses a global switch, and ocaml.org uses a local one, can we be sure that the correct playground switch will be used and not accidentally the local switch of ocaml.org?

@sabine
Copy link
Collaborator

sabine commented Aug 21, 2023

After having working with a global switch for the playground and a local switch for ocaml.org some more, I think the sane solution here is to change the playground Makefile to use a local switch. Then things should naturally fall in place.

@sabine sabine merged commit b153c50 into ocaml:main Aug 23, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants