Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsive layout on releases page #1716

Merged
merged 6 commits into from Nov 15, 2023

Conversation

RWUBAKWANAYO
Copy link
Contributor

Description:

In this pull request, I made significant enhancements to the 'https://ocaml.org/releases' page to improve the user experience on small and medium screens. Instead of using HTML tables, I've replaced them with responsive div containers. This change ensures that the content is displayed optimally on a variety of devices and screen sizes.

In addition to the HTML structure updates, I've also fine-tuned the Tailwind CSS classes for these containers to ensure a proper responsive design. These improvements resolve the issue of content being hidden, eliminating the need for excessive scrolling.

Fixes #1700

@RWUBAKWANAYO RWUBAKWANAYO changed the title Fix issue: collapse table on releases page for small and medium screens Improve responsive layout on releases page Oct 24, 2023
@gpetiot gpetiot added the outreachy Outreachy contributions and blog posts label Oct 24, 2023
Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great work @RWUBAKWANAYO!

Very close to merge, just some smaller adjustments wrt collapsing at md and cleaning up whitespace.

src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/releases.eml Outdated Show resolved Hide resolved
@sabine
Copy link
Collaborator

sabine commented Nov 6, 2023

@RWUBAKWANAYO what is the status on this? Are you interested in continuing to work on this PR? If yes, I'll wait. If no, I'll free the issue for someone else to work on it.

In case help is needed, reach out in the OCaml Discord's #ocaml.org channel.

@RWUBAKWANAYO
Copy link
Contributor Author

@RWUBAKWANAYO what is the status on this? Are you interested in continuing to work on this PR? If yes, I'll wait. If no, I'll free the issue for someone else to work on it.

In case help is needed, reach out in the OCaml Discord's #ocaml.org channel.

@sabine, thank you for reaching out, I'm still interested and I'll make sure to apply the changes by end of tomorrow.

@sabine
Copy link
Collaborator

sabine commented Nov 7, 2023

@RWUBAKWANAYO great, thanks!

@sabine
Copy link
Collaborator

sabine commented Nov 7, 2023

@RWUBAKWANAYO this is very hard to review because you are making unnecessary whitespace/formatting changes, so that the entire file has to be checked line by line.

Can you please reduce the diff by ensuring that unchanged lines are indeed unchanged?

@RWUBAKWANAYO
Copy link
Contributor Author

@sabine, I apologize for the review difficulty caused by changing the indentation from two tabs to one tab which affected the entire file, impacting both styles and code format. If you suggest that I should restrict the changes to styles only, I'm willing to immediately undo the modifications and focus on refining the styles without altering the indentation. Your input is highly appreciated.

@sabine
Copy link
Collaborator

sabine commented Nov 14, 2023

Thanks for the contribution @RWUBAKWANAYO! 👍 Will merge after the CI checks complete.

@sabine sabine merged commit ee83241 into ocaml:main Nov 15, 2023
3 checks passed
sabine pushed a commit to sabine/ocaml.org that referenced this pull request Nov 24, 2023
sabine pushed a commit to balat/ocaml.org that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Outreachy contributions and blog posts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse Table on Releases Page on Small and Medium Screens
3 participants