Remove links from outreachy project description #1764
Conversation
|
@sabine please review the fix and advise further |
data/outreachy.yml
Outdated
| (https://v3.ocaml.org/docs/metaprogramming#attributes-and-derivers) and | ||
| (https://v3.ocaml.org/docs/metaprogramming | ||
| #attributes-and-derivers) and | ||
| extension points | ||
| (https://v3.ocaml.org/docs/metaprogramming#extension-nodes-and-extenders). | ||
| (https://v3.ocaml.org/docs/metaprogramming | ||
| #extension-nodes-and-extenders). |
There was a problem hiding this comment.
I think, since these descriptions are just plain text, they cannot contain URLs in the first place. So the best thing here would be to remove the links.
There was a problem hiding this comment.
That is fine then.
| <% if String.length project.description > 240 then ( %> | ||
| <div :class="is_shown ? '' : 'relative max-h-20 overflow-hidden'"> | ||
| <div class="absolute bottom-0 h-10 left-0 right-0 bg-gradient-to-t from-white"></div> | ||
| <p> <%s project.description %> </p> | ||
| <p class="overflow-fix"> <%s project.description %> </p> |
There was a problem hiding this comment.
overflow-fix doesn't seem defined anywhere and I don't think this file needs to be changed when we remove the offending links from the outreachy descriptions.
There was a problem hiding this comment.
Oh, I added it during debugging and forgot to remove it when I found the bug. Do you need me to take it out or is that already done?
There was a problem hiding this comment.
when you look at the "Files changed" tab, you'll see that two files are being edited by this PR. Best is to check out the old version of outreachy.eml, so the PR doesn't make any changes to this file.
|
I have restored outreachy.eml to the previous state. I only made the change to the data file with the rogue url. You can check now please. |
- fixes overflowing div on outreachy page
- fixes overflowing div on outreachy page
Added a space in the url causing a spill over on mobile