Simplify bootstrapping with dune #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuihtlauac
approved these changes
Nov 24, 2023
|
This is failing on unrelated omd to cmarkit issues: https://deploy.ci.ocaml.org/job/2023-11-24/123654-ocluster-build-2542d1 Is this a transient problem? |
Hi folks 馃憢馃徏 just got around this page and thought it could be simplified a little. Feel free to dismiss if it doesn't meet the expected guidelines/style.
|
Rebased on main after merge of #1642 and force-pushed to see if CI is fine now |
Usually, it's not needed. Re-running the tests is sufficient. However, you have to wait about half an hour for the build fix PR to become active. |
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
sabine
pushed a commit
to balat/ocaml.org
that referenced
this pull request
Dec 12, 2023
* Simplify bootstrapping with dune Hi folks 馃憢馃徏 just got around this page and thought it could be simplified a little. Feel free to dismiss if it doesn't meet the expected guidelines/style. * Update data/tutorials/platform/bp_00_bootstrap_project.md Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com> --------- Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
oyenuga17
pushed a commit
to oyenuga17/ocaml.org
that referenced
this pull request
Jan 8, 2024
* Simplify bootstrapping with dune Hi folks 馃憢馃徏 just got around this page and thought it could be simplified a little. Feel free to dismiss if it doesn't meet the expected guidelines/style. * Update data/tutorials/platform/bp_00_bootstrap_project.md Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com> --------- Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks 馃憢馃徏 just got around this page and thought it could be simplified a little. Feel free to dismiss if it doesn't meet the expected guidelines/style. It includes:
pathparameter that I haven't seen folks use before