Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn UI from Figma #1798

Merged
merged 26 commits into from Nov 30, 2023
Merged

Learn UI from Figma #1798

merged 26 commits into from Nov 30, 2023

Conversation

sabine
Copy link
Collaborator

@sabine sabine commented Nov 27, 2023

Figma: https://www.figma.com/file/bL31M0WWTTdu2z9jAOX77J/UX%2FUI-OCaml-Learn-Area?node-id=2992%3A5091&mode=dev

  • adjust tailwind.config.js to include colors from Design System (Figma)
  • implement Learn landing page components and UI

TODO:

  • landing page video recommendation block
  • tutorial.eml
  • platform.eml
  • exercises.eml
  • books.eml
page before after
overview Screenshot 2023-11-27 at 14-10-03 Learn OCaml Screenshot 2023-11-28 at 21-17-37 Learn OCaml
books Screenshot 2023-11-29 at 17-54-10 OCaml Books Screenshot 2023-11-29 at 17-54-17 OCaml Books
exercises Screenshot 2023-11-29 at 19-02-40 Exercises Screenshot 2023-11-29 at 19-02-30 Exercises

sabine added a commit that referenced this pull request Nov 27, 2023
@sabine sabine marked this pull request as draft November 27, 2023 13:11
sabine added a commit that referenced this pull request Nov 27, 2023
@sabine sabine marked this pull request as ready for review November 29, 2023 14:08
@sabine sabine changed the title Learn Landing Page UI from Figma Learn UI from Figma Nov 29, 2023
@sabine sabine marked this pull request as draft November 29, 2023 15:21
@sabine sabine marked this pull request as ready for review November 30, 2023 16:12
@sabine
Copy link
Collaborator Author

sabine commented Nov 30, 2023

I'll just merge this now as it's in a reasonable enough state. Then Sayo can implement the search results page based off this. Will continue with the open tasks in another PR and deploy fixes / changes as needed.

@sabine sabine merged commit 182432a into ocaml:main Nov 30, 2023
3 checks passed
@sabine sabine deleted the implement_learn_ui branch November 30, 2023 16:15
sabine added a commit to balat/ocaml.org that referenced this pull request Dec 12, 2023
* Figma colors tailwind.config.js, old colors->legacy, tutorial block, hero section
* split hero background in background and camel, scale background
* remove featured+rating on book, book difficulty variant type, lang manual banner draft, books block draft
* add two more book recommendations
* exercises block
* language manual banner background
* better book recommendation text
* move industrial user success story card to template
* platform tools section learn landing, rename legacy cards class
* update border color from Figma, adjust card hover shadow, transform paper cards to new class
* refactor footer
* refactor learn_sidebar into learn_layout
* buttons from design system, substitute legacy primary by new primary, books page
* exercises.eml
* legacy primary-600 and primary-700 to new primary color
oyenuga17 pushed a commit to oyenuga17/ocaml.org that referenced this pull request Jan 8, 2024
* Figma colors tailwind.config.js, old colors->legacy, tutorial block, hero section
* split hero background in background and camel, scale background
* remove featured+rating on book, book difficulty variant type, lang manual banner draft, books block draft
* add two more book recommendations
* exercises block
* language manual banner background
* better book recommendation text
* move industrial user success story card to template
* platform tools section learn landing, rename legacy cards class
* update border color from Figma, adjust card hover shadow, transform paper cards to new class
* refactor footer
* refactor learn_sidebar into learn_layout
* buttons from design system, substitute legacy primary by new primary, books page
* exercises.eml
* legacy primary-600 and primary-700 to new primary color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants