New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(doc) add more info about multiple files #1942
(doc) add more info about multiple files #1942
Conversation
Thanks @heathhenley. I'm sorry I forgot to link to the issue number in my own fix to #1856. It is in PR #1923. You couldn't see I was working on that too. However, your PR addresses the issue in a slightly different manner, it is possible to combine them. Can you rebase this PR after #1923 gets merged? |
Oops, yes no problem I'll rebase on your update after you merge and see if mine still add anything useful. |
We've merged #1923. You can rebase. This will allow shortening your patch since module reexports are no longer needed. My file |
2aafe84
to
90af21b
Compare
@cuihtlauac, I've just rebased and reconciled with your updates. Let me know what you think! |
90af21b
to
452f3d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed to line 213, more to come
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
data/tutorials/getting-started/1_02_your_first_ocaml_program.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
Applied / made the requested changes so far, let me know what else you need. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @sabine, @christinerose do you want to have a look?
Attempting to address #1856 as I learn Ocaml - is something like this example reasonable to add to clear up how to add more files / modules in a library?
Other things:
Sorry if this is way off I don't have really any experience with OCaml yet.