Fix link in 'Other installation methods' collapsible #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @norskeld, the proposed fix looks good, page However, building your PR on my machine creates a binary that crashes when rendering |
|
Probably linked to #1956 Can you rebase on this? |
Previously the 'install opam using your operating system's package manager' link led to 'A Tour of OCaml' page.
norskeld
force-pushed
the
fix-install-link
branch
from
780f75c
to
c5851c4
Compare
|
@cuihtlauac (Hopefuly) done! 😄 Let me know if everything's ok now. |
|
Works fine now, this was indeed the issue mentioned, nothing on you. Thank a lot. |
cuihtlauac
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Noticed that the 'install opam using your operating system's package manager' link on the https://ocaml.org/install page (in 'Other installation methods' collapsible) leads to https://ocaml.org/docs/tour-of-ocaml#1-install-opam, which is not correct AFAICS.