Simplify typing of recommended next tutorials #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the type of `Data.Tutorial.t.recommended_next_tutorial` a `list` instead of an `list option`. If the Yaml header is missing or if it contains an empty list, it will result into a empty list. This avoids having to handle the `Some []` case which is redundant.
cuihtlauac
force-pushed
the
no-opt-also-read-tutos
branch
from
88cf623
to
42698df
Compare
sabine
approved these changes
Jan 18, 2024
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the type of
Data.Tutorial.t.recommended_next_tutorialalistinstead of a
list option. If the Yaml header is missing or if itcontains an empty list, it will result into a empty list. This avoids
having to handle the
Some []case which is redundant.