Implement dark mode on homepage and tutorial search page #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sabine i really don't know where tutorial_search.eml appears on the website so I only changed the legacy colours I am familiar with, maybe you can please point me to it. Thank you. |
|
It is here: https://ocaml.org/docs/search?q=function People arrive there from the documentation search bar. |
I don't think this tertiary colour looks good on an orange text for the dark mode @sabine please what do you suggest. |
|
Try this highlight color for the search terms: https://www.figma.com/file/eh8gAxaxrZT6RG3psHCm6M/Dark-%26-Light-mode-pages?type=design&node-id=373%3A26364&mode=design&t=GAweNYDVoW8NMd16-1
|
sabine
changed the title
sabine
added a commit
that referenced
this pull request
Feb 20, 2024
SaySayo
reviewed
Feb 22, 2024
src/ocamlorg_frontend/pages/home.eml
Outdated
| @@ -1,6 +1,6 @@ | |||
| let package_card ~href ~img_path ~name description = | |||
| <a href="<%s href %>" target="_blank" | |||
| class="bg-legacy-default dark:bg-legacy-dark-default text-legacy-default dark:text-legacy-dark-default p-4 rounded-xl flex md:gap-2 items-center legacy-card-hover"> | |||
| class="bg-legacy-default dark:bg-legacy-dark-default text-title dark:text-dark-title p-4 rounded-xl flex md:gap-2 items-center legacy-card-hover"> | |||
There was a problem hiding this comment.
Suggested change
| class="bg-legacy-default dark:bg-legacy-dark-default text-title dark:text-dark-title p-4 rounded-xl flex md:gap-2 items-center legacy-card-hover"> | |
| class="bg-white dark:bg-dark-background text-title dark:text-dark-title p-4 rounded-xl flex md:gap-2 items-center legacy-card-hover"> |
| </div> | ||
| <div> | ||
| <div class="text-base text-legacy-default"> | ||
| <p class="text-base text-content dark:text-dark-content"> |
There was a problem hiding this comment.
Suggested change
| <p class="text-base text-content dark:text-dark-content"> | |
| <p class="text-base text-title dark:text-dark-title"> |
src/ocamlorg_frontend/pages/home.eml
Outdated
| <h2 class="font-bold">OCaml Packages</h2> | ||
| <p class="text-lg text-legacy-lighter"> | ||
| <h2 class="font-bold text-title dark:text-dark-title">OCaml Packages</h2> | ||
| <p class="text-lg text-title dark:text-dark-title"> |
There was a problem hiding this comment.
Suggested change
| <p class="text-lg text-title dark:text-dark-title"> | |
| <p class="text-lg text-content dark:text-dark-content"> |
|
@sabine I am now ready for a review, thank you. |
-toc.eml -tutorial_search.eml
sabine
force-pushed
the
darkmode-home-eml-pages
branch
from
621f183
to
7827968
Compare
sabine
added a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SaySayo please review.