Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the duplicated "Docs" link and make it looks like the figma #2116

Merged
merged 2 commits into from Feb 29, 2024

Conversation

kiyov09
Copy link
Contributor

@kiyov09 kiyov09 commented Feb 29, 2024

Fixing #2110

@kiyov09
Copy link
Contributor Author

kiyov09 commented Feb 29, 2024

Hi @sabine , I think I'm done with this one. Below there is a list of screenshots showing the result.

Note: I only touched the Docs links styles, the rest of the dropdown remains unchanged

Light mode

Default

Screenshot 2024-02-28 at 17 59 27

Hover / focus

Screenshot 2024-02-28 at 18 00 40

Dark mode

Default

Screenshot 2024-02-28 at 17 59 53

Hover / focus

Screenshot 2024-02-28 at 18 00 13

Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @kiyov09! That's a great help, merging this right away! ✨

@sabine sabine merged commit efcf656 into ocaml:main Feb 29, 2024
2 of 3 checks passed
@kiyov09 kiyov09 deleted the fix/duplicate_docs_link_search_dropdown branch February 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants