Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Events Directory #2132

Merged
merged 3 commits into from Mar 5, 2024
Merged

Improve Events Directory #2132

merged 3 commits into from Mar 5, 2024

Conversation

sabine
Copy link
Collaborator

@sabine sabine commented Mar 4, 2024

  • removes past event
  • makes date and time format more clear - all times and dates are to be entered in UTC
  • display start and end times, if applicable
  • move logic that chooses which events to display to handler.ml

@tmattio
Copy link
Collaborator

tmattio commented Mar 5, 2024

I would recommend not deleting historical data. Maybe a flag to hide past events would be more appropriate?

@sabine
Copy link
Collaborator Author

sabine commented Mar 5, 2024

They're hidden anyways since their start/end dates are in the past. But if you prefer to keep them around, no problem.

@sabine sabine merged commit 23b67ce into ocaml:main Mar 5, 2024
2 of 3 checks passed
@sabine sabine deleted the remove_past_events branch March 5, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinerose christinerose Awaiting requested review from christinerose christinerose is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sabine @tmattio