Explain why t-first works with labels #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change solves ocaml#2083 by adding the explanation with examples in the Labelled and Optional Arguments tutorial.
mikhailazaryan
changed the title
mikhailazaryan
changed the title
cuihtlauac
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks @mikhailazaryan, this is really useful. I'm proposing a couple of changes. I believe explaining the motivation for t-first function signatures is needed.
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
|
Thanks for the feedback. I adjusted the text, taking your remarks into account. |
christinerose
approved these changes
Mar 11, 2024
cuihtlauac
requested changes
Mar 11, 2024
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
|
Fixed |
cuihtlauac
approved these changes
Mar 11, 2024
|
Thank you too for your remarks @cuihtlauac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves #2083 by adding the explanation with examples in the Labelled and Optional Arguments tutorial.